From: "Heiko Stübner" <heiko@sntech.de> To: Tomasz Figa <tfiga@chromium.org> Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>, Helen Koike <helen.koike@collabora.com>, Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Linux Media Mailing List <linux-media@vger.kernel.org>, linux-devicetree <devicetree@vger.kernel.org> Subject: Re: [PATCH v2 0/3] media: rockchip: Introduce driver for the camera interface on PX30 Date: Mon, 01 Jun 2020 23:38:34 +0200 Message-ID: <1779471.kMuJgyiE6z@diego> (raw) In-Reply-To: <CAAFQd5AVD+LhYZziqNUfga1sCp98MMu+ESgBMagS1n6++ae=pg@mail.gmail.com> Hi Tomasz, Am Montag, 1. Juni 2020, 20:45:14 CEST schrieb Tomasz Figa: > On Fri, May 29, 2020 at 3:04 PM Maxime Chevallier > <maxime.chevallier@bootlin.com> wrote: > > > > Hello everyone, > > > > Here's a V2 of the series adding very basic support for the camera interface on > > the Rockchip PX30 SoC. > > > > Thanks to everyone that commented on the first series, your reviews were > > very helpful :) > > > > This Camera Interface is also supported on other Rockchip SoC such as > > the RK1808, RK3128, RK3288 and RK3288, but for now I've only been able to > > test it on the PX30, using a PAL format. > > How does this hardware relate to the one handled by the rkisp1 driver > that is available under staging/media/rkisp1? It was written with > RK3399 in mind, but I have a loose recollection that the hardware in > RK3288 was roughly the same. (un-)educated guess would be that the rk3288 has both. When introducing new IPs Rockchip often keeps the previous incarnation around - probably as a fallback. From a bit of digging around manuals and vendor-dtsi [0] I found: in rk3288.dtsi both: - isp: isp@ff910000 - cif_isp0: cif_isp@ff910000 - grf_con_disable_isp in GRF_SOC_CON6 - dphy_rx1_src_sel (1: isp, 0: csi host) in GRF_SOC_CON14 Heiko [0] https://github.com/rockchip-linux/kernel/blob/develop-4.4/arch/arm/boot/dts/rk3288.dtsi > +Helen Koike +Dafna Hirschfeld working on the rkisp1 driver. > > Best regards, > Tomasz > > > > > This driver is mostly based on the driver found in Rockchip's BSP, that > > has been trimmed down to support the set of features that I was able to test, > > that is pretty much a very basic one-frame capture and video streaming > > with GStreamer. > > > > This first draft only supports the Parallel interface, although the > > controller has support for BT656 and CSI2. > > > > Finally, this controller has an iommu that could be used in this driver, > > but as of today I've not been able to get it to work. > > > > Any review is welcome. > > > > Thanks, > > > > Maxime > > > > --- Changes since V1 --- > > > > - Took reviews from Rob, Hans, Robin and Heiko into account : > > - Renamed the clocks in the binding > > - Fixed the DT schema compiling > > - Fixed a few typos > > - Used the clk bulk API > > - Used the reset array API > > - Changed a few helpers for more suitable ones > > - Rebased on 5.7-rc7 > > > > > > > > Maxime Chevallier (3): > > media: dt-bindings: media: Document Rockchip CIF bindings > > media: rockchip: Introduce driver for Rockhip's camera interface > > arm64: dts: rockchip: Add the camera interface description of the PX30 > > > > .../bindings/media/rockchip-cif.yaml | 100 ++ > > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 + > > drivers/media/platform/Kconfig | 13 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/rockchip/cif/Makefile | 3 + > > drivers/media/platform/rockchip/cif/capture.c | 1170 +++++++++++++++++ > > drivers/media/platform/rockchip/cif/dev.c | 358 +++++ > > drivers/media/platform/rockchip/cif/dev.h | 213 +++ > > drivers/media/platform/rockchip/cif/regs.h | 256 ++++ > > 9 files changed, 2126 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/rockchip-cif.yaml > > create mode 100644 drivers/media/platform/rockchip/cif/Makefile > > create mode 100644 drivers/media/platform/rockchip/cif/capture.c > > create mode 100644 drivers/media/platform/rockchip/cif/dev.c > > create mode 100644 drivers/media/platform/rockchip/cif/dev.h > > create mode 100644 drivers/media/platform/rockchip/cif/regs.h > > > > -- > > 2.25.4 > > >
next prev parent reply other threads:[~2020-06-01 21:38 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 13:04 Maxime Chevallier 2020-05-29 13:04 ` [PATCH v2 1/3] media: dt-bindings: media: Document Rockchip CIF bindings Maxime Chevallier 2020-05-29 16:14 ` Rob Herring 2020-05-29 13:04 ` [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface Maxime Chevallier 2020-05-31 4:39 ` kbuild test robot 2020-05-31 12:16 ` kbuild test robot 2020-05-31 13:40 ` Ezequiel Garcia 2020-07-09 7:35 ` Maxime Chevallier 2020-07-09 18:06 ` Dafna Hirschfeld 2020-05-29 13:04 ` [PATCH v2 3/3] arm64: dts: rockchip: Add the camera interface description of the PX30 Maxime Chevallier 2020-06-01 18:45 ` [PATCH v2 0/3] media: rockchip: Introduce driver for the camera interface on PX30 Tomasz Figa 2020-06-01 21:38 ` Heiko Stübner [this message] 2020-06-04 17:04 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1779471.kMuJgyiE6z@diego \ --to=heiko@sntech.de \ --cc=dafna.hirschfeld@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Unnamed repository; edit this file 'description' to name the repository. This inbox may be cloned and mirrored by anyone: git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \ linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net public-inbox-index linux-media Example config snippet for mirrors. Newsgroup available over NNTP: nntp://archive.lwn.net/lwn.kernel.linux-media AGPL code for this site: git clone https://public-inbox.org/public-inbox.git