* [PATCH] dt-bindings: media: Add missing clock domain description
@ 2020-05-19 7:42 Geert Uytterhoeven
2020-05-21 12:05 ` Jacopo Mondi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-05-19 7:42 UTC (permalink / raw)
To: Jacopo Mondi, Mauro Carvalho Chehab, Rob Herring
Cc: linux-media, linux-renesas-soc, devicetree, Geert Uytterhoeven
make dtbs_check:
arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
Fix this by documenting the missing properties.
Update the example to match reality.
Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'")
Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
index f2393458814ee08f..c7e1e4fe67e6696b 100644
--- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
@@ -27,6 +27,12 @@ properties:
interrupts:
maxItems: 1
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
port:
type: object
additionalProperties: false
@@ -57,6 +63,8 @@ required:
- compatible
- reg
- interrupts
+ - clocks
+ - power-domains
- port
additionalProperties: false
@@ -64,11 +72,14 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/r7s72100-clock.h>
ceu: ceu@e8210000 {
reg = <0xe8210000 0x209c>;
compatible = "renesas,r7s72100-ceu";
interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp6_clks R7S72100_CLK_CEU>;
+ power-domains = <&cpg_clocks>;
port {
ceu_in: endpoint {
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Add missing clock domain description
2020-05-19 7:42 [PATCH] dt-bindings: media: Add missing clock domain description Geert Uytterhoeven
@ 2020-05-21 12:05 ` Jacopo Mondi
2020-05-28 21:05 ` Rob Herring
2020-05-28 21:05 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Jacopo Mondi @ 2020-05-21 12:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Rob Herring, linux-media,
linux-renesas-soc, devicetree
Hi Geert,
On Tue, May 19, 2020 at 09:42:29AM +0200, Geert Uytterhoeven wrote:
> make dtbs_check:
>
> arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fix this by documenting the missing properties.
> Update the example to match reality.
Thanks for fixing this!
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'")
> Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.yaml b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> index f2393458814ee08f..c7e1e4fe67e6696b 100644
> --- a/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,ceu.yaml
> @@ -27,6 +27,12 @@ properties:
> interrupts:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> port:
> type: object
> additionalProperties: false
> @@ -57,6 +63,8 @@ required:
> - compatible
> - reg
> - interrupts
> + - clocks
> + - power-domains
> - port
>
> additionalProperties: false
> @@ -64,11 +72,14 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/r7s72100-clock.h>
>
> ceu: ceu@e8210000 {
> reg = <0xe8210000 0x209c>;
> compatible = "renesas,r7s72100-ceu";
> interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp6_clks R7S72100_CLK_CEU>;
> + power-domains = <&cpg_clocks>;
>
> port {
> ceu_in: endpoint {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Add missing clock domain description
2020-05-19 7:42 [PATCH] dt-bindings: media: Add missing clock domain description Geert Uytterhoeven
2020-05-21 12:05 ` Jacopo Mondi
@ 2020-05-28 21:05 ` Rob Herring
2020-05-28 21:05 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-05-28 21:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jacopo Mondi, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, devicetree
On Tue, May 19, 2020 at 09:42:29AM +0200, Geert Uytterhoeven wrote:
> make dtbs_check:
>
> arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fix this by documenting the missing properties.
> Update the example to match reality.
>
> Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'")
The above is not a error in this commit. It just exposed an error in
the binding. So I don't think Fixes is appropriate. I'll drop when
applying.
> Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: media: Add missing clock domain description
2020-05-19 7:42 [PATCH] dt-bindings: media: Add missing clock domain description Geert Uytterhoeven
2020-05-21 12:05 ` Jacopo Mondi
2020-05-28 21:05 ` Rob Herring
@ 2020-05-28 21:05 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-05-28 21:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-renesas-soc, Rob Herring, devicetree, linux-media,
Mauro Carvalho Chehab, Jacopo Mondi
On Tue, 19 May 2020 09:42:29 +0200, Geert Uytterhoeven wrote:
> make dtbs_check:
>
> arch/arm/boot/dts/r7s72100-genmai.dt.yaml: camera@e8210000: 'clocks', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fix this by documenting the missing properties.
> Update the example to match reality.
>
> Fixes: 7f464532b05dadc8 ("dt-bindings: Add missing 'additionalProperties: false'")
> Fixes: 58361eaa11d561f3 ("dt-bindings: media: renesas,ceu: Convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/media/renesas,ceu.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 21:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 7:42 [PATCH] dt-bindings: media: Add missing clock domain description Geert Uytterhoeven
2020-05-21 12:05 ` Jacopo Mondi
2020-05-28 21:05 ` Rob Herring
2020-05-28 21:05 ` Rob Herring
Unnamed repository; edit this file 'description' to name the repository.
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \
linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net
public-inbox-index linux-media
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://archive.lwn.net/lwn.kernel.linux-media
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git