From: Nathan Chancellor <natechancellor@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it Date: Fri, 29 May 2020 19:55:53 -0700 Message-ID: <20200530025553.GA1367069@ubuntu-s3-xlarge-x86> (raw) In-Reply-To: <20200529200031.4117841-2-arnd@arndb.de> On Fri, May 29, 2020 at 10:00:24PM +0200, Arnd Bergmann wrote: > In some configurations, including this header leads to a warning: > > drivers/staging/media/atomisp//pci/sh_css_firmware.h:41:38: error: declaration of 'struct device' will not be visible outside of this function [-Werror,-Wvisibility] > > Make sure the struct tag is known before declaring a function > that uses it as an argument. > > Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/staging/media/atomisp/pci/sh_css_firmware.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.h b/drivers/staging/media/atomisp/pci/sh_css_firmware.h > index f6253392a6c9..317559c7689f 100644 > --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.h > +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.h > @@ -37,6 +37,7 @@ extern unsigned int sh_css_num_binaries; > char > *sh_css_get_fw_version(void); > > +struct device; > bool > sh_css_check_firmware_version(struct device *dev, const char *fw_data); > > -- > 2.26.2 >
next prev parent reply other threads:[~2020-05-30 2:56 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 20:00 [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Arnd Bergmann 2020-05-29 20:00 ` [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it Arnd Bergmann 2020-05-30 2:55 ` Nathan Chancellor [this message] 2020-05-29 20:00 ` [PATCH 3/9] staging: media: atomisp: annotate an unused function Arnd Bergmann 2020-05-30 2:56 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 4/9] staging: media: atomisp: fix a type conversion warning Arnd Bergmann 2020-05-29 20:00 ` [PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults() Arnd Bergmann 2020-05-30 2:57 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 6/9] staging: media: atomisp: fix type mismatch Arnd Bergmann 2020-05-29 20:00 ` [PATCH 7/9] staging: media: atomisp: fix enum type mixups Arnd Bergmann 2020-05-30 3:00 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 8/9] staging: media: atomisp: disable all custom formats Arnd Bergmann 2020-05-30 3:03 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency Arnd Bergmann 2020-05-30 3:11 ` Nathan Chancellor 2020-05-30 5:25 ` Mauro Carvalho Chehab 2020-05-29 20:04 ` [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Nick Desaulniers 2020-05-29 20:23 ` Arnd Bergmann 2020-05-29 20:31 ` Arnd Bergmann 2020-05-30 2:49 ` Nathan Chancellor 2020-05-30 9:22 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200530025553.GA1367069@ubuntu-s3-xlarge-x86 \ --to=natechancellor@gmail.com \ --cc=arnd@arndb.de \ --cc=clang-built-linux@googlegroups.com \ --cc=devel@driverdev.osuosl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Unnamed repository; edit this file 'description' to name the repository. This inbox may be cloned and mirrored by anyone: git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \ linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net public-inbox-index linux-media Example config snippet for mirrors. Newsgroup available over NNTP: nntp://archive.lwn.net/lwn.kernel.linux-media AGPL code for this site: git clone https://public-inbox.org/public-inbox.git