Unnamed repository; edit this file 'description' to name the repository.
 help / color / mirror / Atom feed
* [linux-next:master 10308/14131] drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true'
@ 2020-05-30  2:32 kbuild test robot
  0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-05-30  2:32 UTC (permalink / raw)
  To: Mauro, Carvalho, Chehab,; +Cc: kbuild-all, clang-built-linux, linux-media

[-- Attachment #1: Type: text/plain, Size: 24203 bytes --]

Hi Mauro,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e7b08814b16b80a0bf76eeca16317f8c2ed23b8c
commit: 085093606320ac76a062c99cf12e33c010417b4b [10308/14131] media: atomisp: allow building for isp2401
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2d068e534f1671459e1b135852c1b3c10502e929)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout 085093606320ac76a062c99cf12e33c010417b4b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true' [-Wpointer-bool-conversion]
} else if (&binary->in_frame_info) {
~~   ~~~~~~~~^~~~~~~~~~~~~
1 warning generated.

vim +1039 drivers/staging/media/atomisp/pci/sh_css_sp.c

ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   937  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   938  	initialize_stage_frames(&sh_css_sp_stage.frames);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   939  	/*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   940  	 * TODO: Make the Host dynamically determine
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   941  	 * the stage type.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   942  	 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   943  	sh_css_sp_stage.stage_type = SH_CSS_ISP_STAGE_TYPE;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   944  	sh_css_sp_stage.num		= (uint8_t)stage;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   945  	sh_css_sp_stage.isp_online	= (uint8_t)binary->online;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   946  	sh_css_sp_stage.isp_copy_vf     = (uint8_t)args->copy_vf;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   947  	sh_css_sp_stage.isp_copy_output = (uint8_t)args->copy_output;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   948  	sh_css_sp_stage.enable.vf_output = (args->out_vf_frame != NULL);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   949  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   950  	/* Copy the frame infos first, to be overwritten by the frames,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   951  	   if these are present.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   952  	*/
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   953  	sh_css_sp_stage.frames.effective_in_res.width = binary->effective_in_frame_res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   954  	sh_css_sp_stage.frames.effective_in_res.height = binary->effective_in_frame_res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   955  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   956  	ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.in.info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   957  					   &binary->in_frame_info);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   958  	for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   959  	{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   960  		ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.out[i].info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   961  						   &binary->out_frame_info[i]);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   962  	}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   963  	ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.internal_frame_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   964  					   &binary->internal_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   965  	sh_css_sp_stage.dvs_envelope.width    = binary->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   966  	sh_css_sp_stage.dvs_envelope.height   = binary->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   967  	sh_css_sp_stage.isp_pipe_version      = (uint8_t)info->pipeline.isp_pipe_version;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   968  	sh_css_sp_stage.isp_deci_log_factor   = (uint8_t)binary->deci_factor_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   969  	sh_css_sp_stage.isp_vf_downscale_bits = (uint8_t)binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   970  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   971  	sh_css_sp_stage.if_config_index = (uint8_t)if_config_index;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   972  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   973  	sh_css_sp_stage.sp_enable_xnr = (uint8_t)xnr;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   974  	sh_css_sp_stage.xmem_bin_addr = xinfo->xmem_addr;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   975  	sh_css_sp_stage.xmem_map_addr = sh_css_params_ddr_address_map();
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   976  	sh_css_isp_stage.blob_info = *blob_info;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   977  	sh_css_stage_write_binary_info((struct ia_css_binary_info *)info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   978  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   979  	/* Make sure binary name is smaller than allowed string size */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   980  	assert(strlen(binary_name) < SH_CSS_MAX_BINARY_NAME - 1);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   981  	strncpy(sh_css_isp_stage.binary_name, binary_name, SH_CSS_MAX_BINARY_NAME - 1);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   982  	sh_css_isp_stage.binary_name[SH_CSS_MAX_BINARY_NAME - 1] = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   983  	sh_css_isp_stage.mem_initializers = *isp_mem_if;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   984  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   985  	/*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   986  	 * Even when a stage does not need uds and does not params,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   987  	 * ia_css_uds_sp_scale_params() seems to be called (needs
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   988  	 * further investigation). This function can not deal with
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   989  	 * dx, dy = {0, 0}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   990  	 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   991  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   992  	err = sh_css_sp_write_frame_pointers(args);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   993  	/* TODO: move it to a better place */
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   994  	if (binary->info->sp.enable.s3a)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   995  	{
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   996  		ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_3A_STATISTICS, thread_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   997  					       &queue_id);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   998  		sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.s3a_buf, queue_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19   999  						    mmgr_EXCEPTION,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1000  						    IA_CSS_BUFFER_TYPE_3A_STATISTICS);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1001  	}
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1002  	if (binary->info->sp.enable.dis)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1003  	{
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1004  		ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_DIS_STATISTICS, thread_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1005  					       &queue_id);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1006  		sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.dvs_buf, queue_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1007  						    mmgr_EXCEPTION,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1008  						    IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1009  	}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1010  #if defined SH_CSS_ENABLE_METADATA
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1011  	ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1012  	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1013  #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1014  	if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1015  		return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1016  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1017  #ifdef USE_INPUT_SYSTEM_VERSION_2401
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1018  #ifndef ISP2401
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1019  	if (args->in_frame)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1020  	{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1021  		pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1022  		if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1023  			return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1024  		ia_css_get_crop_offsets(pipe, &args->in_frame->info);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1025  	} else if (&binary->in_frame_info)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1026  	{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1027  		pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1028  		if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1029  			return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1030  		ia_css_get_crop_offsets(pipe, &binary->in_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1031  #else
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1032  	if (stage == 0)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1033  	{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1034  		if (args->in_frame) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1035  			pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1036  			if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1037  				return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1038  			ia_css_get_crop_offsets(pipe, &args->in_frame->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 @1039  		} else if (&binary->in_frame_info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1040  			pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1041  			if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1042  				return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1043  			ia_css_get_crop_offsets(pipe, &binary->in_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1044  		}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1045  #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1046  	}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1047  #else
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1048  	(void)pipe; /*avoid build warning*/
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1049  #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1050  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1051  	err = configure_isp_from_args(&sh_css_sp_group.pipe[thread_id],
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1052  				      binary, args, two_ppc, sh_css_sp_stage.deinterleaved);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1053  	if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1054  		return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1055  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1056  	initialize_isp_states(binary);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1057  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1058  	/* we do this only for preview pipe because in fill_binary_info function
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1059  	 * we assign vf_out res to out res, but for ISP internal processing, we need
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1060  	 * the original out res. for video pipe, it has two output pins --- out and
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1061  	 * vf_out, so it can keep these two resolutions already. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1062  	if (binary->info->sp.pipeline.mode == IA_CSS_BINARY_MODE_PREVIEW &&
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1063  	    (binary->vf_downscale_log2 > 0))
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1064  	{
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1065  		/* TODO: Remove this after preview output decimation is fixed
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1066  		 * by configuring out&vf info fiels properly */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1067  		sh_css_sp_stage.frames.out[0].info.padded_width
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1068  		<<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1069  		sh_css_sp_stage.frames.out[0].info.res.width
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1070  		<<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1071  		sh_css_sp_stage.frames.out[0].info.res.height
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1072  		<<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1073  	}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1074  	err = copy_isp_mem_if_to_ddr(binary);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1075  	if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1076  		return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1077  
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1078  	return IA_CSS_SUCCESS;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1079  }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19  1080  

:::::: The code at line 1039 was first introduced by commit
:::::: ad85094b293e40e7a2f831b0311a389d952ebd5e Revert "media: staging: atomisp: Remove driver"

:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73686 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-30  4:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30  2:32 [linux-next:master 10308/14131] drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true' kbuild test robot

Unnamed repository; edit this file 'description' to name the repository.

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \
		linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net
	public-inbox-index linux-media

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://archive.lwn.net/lwn.kernel.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git