Unnamed repository; edit this file 'description' to name the repository.
 help / color / mirror / Atom feed
* Re: [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open()
@ 2020-05-31 16:06 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-31 16:06 UTC (permalink / raw)
  To: Dinghao Liu, Sylwester Nawrocki, linux-arm-kernel, linux-media,
	linux-samsung-soc
  Cc: kernel-janitors, linux-kernel, Kangjie Lu, Krzysztof Kozlowski,
	Kukjin Kim, Kyungmin Park, Mauro Carvalho Chehab

> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.

How do you think about a wording variant like the following?

   Change description:
   The PM runtime usage counter is incremented even if a call of
   the function “pm_runtime_get_sync” failed. Thus decrement it also
   in an error case so that the reference counting is kept consistent.


Would you like to add the tag “Fixes” to the commit message?


Can it make sense to combine the software adjustment with the
update step “media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe”?
https://lore.kernel.org/linux-arm-kernel/20200524025903.17219-1-dinghao.liu@zju.edu.cn/
https://lore.kernel.org/patchwork/patch/1246424/


…
+++ b/drivers/media/platform/exynos4-is/fimc-isp-video.c
@@ -293,6 +293,7 @@  static int isp_video_open(struct file *file)
 	if (!ret)
 		goto unlock;
 rel_fh:
+	pm_runtime_put_noidle(&isp->pdev->dev);
 	v4l2_fh_release(file);
 unlock:
…

Is there a need to use a label like “put_pm”?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-31 16:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31 16:06 [PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open() Markus Elfring

Unnamed repository; edit this file 'description' to name the repository.

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \
		linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net
	public-inbox-index linux-media

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://archive.lwn.net/lwn.kernel.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git