From: Markus Elfring <Markus.Elfring@web.de>
To: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sean Young <sean@mess.org>
Subject: Re: [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow in debiirq()
Date: Sat, 30 May 2020 17:27:48 +0200
Message-ID: <e9624d66-5466-7b7d-4fb9-af73b995e7f2@web.de> (raw)
> To fix this possible bug, data[0] is assigned to a local variable, which
> replaces the use of data[0].
How do you think about a wording variant like the following?
Thus assign the first element of the data array to a local variable
so that it can be used as an array index together with the data structure
member “ci_slot” in a safer way.
Would you like to add the tag “Fixes” to the commit message?
Are you going to take this possibility into account for any more patches?
Regards,
Markus
reply other threads:[~2020-05-30 15:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9624d66-5466-7b7d-4fb9-af73b995e7f2@web.de \
--to=markus.elfring@web.de \
--cc=baijiaju@tsinghua.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Unnamed repository; edit this file 'description' to name the repository.
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://archive.lwn.net:8080/linux-media/0 linux-media/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-media linux-media/ http://archive.lwn.net:8080/linux-media \
linux-media@vger.kernel.org lwn-linux-media@archive.lwn.net
public-inbox-index linux-media
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://archive.lwn.net/lwn.kernel.linux-media
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git